fix(ci): give the release-notes job a repo to talk to#283
Merged
Conversation
The notes job runs without actions/checkout, so gh had no git remote to infer the repository from and died with "fatal: not a git repository" before it could edit the release. GH_REPO tells gh directly, which is cheaper than checking out the tree just to name a repo. The bundle uploads in the same run all succeeded, including the Windows one that the shell: bash fix repaired, so only the notes step was affected. v0.3.0's notes were applied by hand; this makes the next release do it on its own.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the plugin-release.yml release-notes (notes) job by explicitly telling the GitHub CLI which repository to target, avoiding the need for a checkout just to infer a git remote.
Changes:
- Set
GH_REPO: ${{ github.repository }}for the “Append plugin download table” step sogh release view/editworks without a.gitdirectory. - Add inline comments documenting why
GH_REPOis required in this job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
OpenSauce
enabled auto-merge (squash)
July 26, 2026 12:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #282. The Windows upload fix worked — all three plugin bundles are attached to v0.3.0 — but the new
notesjob failed:The job deliberately has no
actions/checkout(it only edits a release, it needs no source), soghhad no git remote to infer the repository from.GH_REPOtells it directly, which is cheaper than checking out the tree just to name a repo.Only the notes step was affected — every bundle upload in that run succeeded, including the Windows one repaired by #282's
shell: bashfix.v0.3.0 status
Complete and published. All four archives attached, and the plugin download table was applied by hand with the same content and marker the job generates, so a future re-dispatch for that tag will correctly skip it as already present.
This change makes the next release do it unattended.
Verification
Same limitation as #282: the
notesjob only runs off a real release, so this gets its first live exercise at v0.4.0. The generated markdown itself is verified — it's exactly what was published to v0.3.0.